Repository navigation
Conversation
The extension only recognised `.zip`, so archives that are zip containers under another extension (.jar, .war, .apk, .ipa, .crx) could not be mounted and had to be renamed first. `ZipOpenFS` already accepts a `fileExtensions` option for exactly this, so pass the list through instead of special-casing `.zip`, and use the same list for the `stat()` type check that decides whether a path is presented as a directory. The `languages` and `activationEvents` contributions are updated to match, so the files get the `zip` language id (which the mount/unmount explorer menus key off) and the extension activates when they are present. Closes: yarnpkg#6077
clemyan
requested changes
Oct 12, 2026
clemyan
left a comment
Member
There was a problem hiding this comment.
default that list to
.zipso nothing changes for existing users. The list is exposed as ayarn.zipfsExtensionssetting so it can be extended without a code change.
This is not reflected in the code changes
Author
|
@clemyan You're right, that sentence described a setting the code doesn't add. I've corrected the description: the PR only adds the fixed list from #6077 ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Closes #6077.
The VS Code ZipFS extension only recognizes
.zip. Zip-compatible archives with other extensions cannot be mounted through the same provider.How did you fix it?
Use the same fixed list of six extensions in
ZipFSProviderand the extension's activation/language contributions:.zip,.jar,.war,.apk,.ipaand.crx.ZIP_ARCHIVE_EXTENSIONSis passed toZipOpenFS.fileExtensionsand used when reporting an archive as a directory. The package contributions activate the extension and recognize the added formats. The release file marksvscode-zipfsfor a minor release.This implementation adds a fixed list; it does not add a
yarn.zipfsExtensionssetting or support.ear/.xpi. The earlier description incorrectly claimed those behaviors.Validation
Checked the current diff at
0b1bbf5591433c4dd55790b0fe1e9beee5bbc8c4against the provider and package contributions. I did not launch VS Code or exercise the extension end to end in this update. The Integration workflow still has failures in its Windows Node.js nightly jobs; this description update does not resolve or claim those checks passed.Checklist