[gahaas]

In the examples where v8::FastApiTypedArray was used, there is actually no advantage of using V8's fast API calls instead of regular API calls. Therefore this CL just removes the fast API call targets instead of adjusting them.

[ronag]

@gahaas we have been benchmarking alternatives to v8::FastApiTypedArray and they are all significantly slower.¨

Refs: nodejs#54103
Refs: nodejs#54087

[gahaas]

@ronag What exactly did you measure? If I remember correctly, the performance regression of removing v8::FastApiTypedArray was 6 CPU cycles per call. In a micro-benchmark that calls an empty API function, this regression was indeed clearly measurable, but as soon as I added reasonable workload, I could not measure a difference anymore.

[ronag]

memmove 64 bytes.

[ronag]

Pleas see the references

[gahaas]

Thank you for making me aware of this issue. Could you please file a bug in the V8 bug tracker.

Please add information on how I can reproduce the issue locally.

Does node compile with PGO and LTO? I could imagine that the issue is that some API function calls get inlined in Chrome but not in node, as that would explain the different performance behavior.

[ronag]

Does node compile with PGO and LTO? I could imagine that the issue is that some API function calls get inlined in Chrome but not in node, as that would explain the different performance behavior.

@targos Do you know someone that can answer this?

[ronag]

@gahaas https://issues.chromium.org/u/0/issues/356158110