Repository navigation
Track only move paths of dropped locals in MaybeInitializedPlaces - #164434
Open
Ramneet-Singh wants to merge 2 commits into
Open
Ramneet-Singh wants to merge 2 commits into
Ramneet-Singh wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @jackh726 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
Disclosure: An LLM was used to explore and understand the codebase, but all code here is written fresh. |
Member
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
…it, r=<try> Track only move paths of dropped locals in MaybeInitializedPlaces
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Author
|
The CI failure seems to be a Bad Gateway Error due to a network blip while fetching from the yarn package registry: Could we retry the failing check? |
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (d692ff4): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @bors rollup=iffy rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 488.875s -> 489.109s (0.05%) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop-liveness reads only the move paths of locals that have drop points. Track only these move paths in the MaybeInitializedPlaces dataflow analysis, because a large function can have thousands of move paths which aren't required to be tracked.