Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 11, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intersects('>1.0.0-alpha', '<1.0.0-alpha.0')returns true, even though no version can fall strictly between those bounds. Appending.0to a prerelease gives its immediate successor under SemVer precedence.Reject this pair of exclusive bounds in either order in
Comparator.intersects. Use already normalized versions so build metadata and loose numeric normalization retain their existing behavior. Add regressions and controls for the public range API, Range/Comparator objects, inclusive endpoints, wider gaps, numeric/nested identifiers, build metadata, loose parsing, and OR branches.This is separate from wildcard handling in #914 and the shared-prerelease-excluded paths in #901. It does not attempt to resolve the known below-zero (#885) or large-numeric-precision (#880) issues.
Validation
npm test: all 51 test files pass, with 100% statements, branches, functions and lines; posttest ESLint and template-oss-check pass.AI assistance: OpenAI Codex was used for investigation, implementation, tests and automated validation. No human review is claimed. Hosted CI has not run yet.