Repository navigation
Conversation
…eanMocks() Since nodejs#5648, MockAgent shares a pool's interceptors array with the `${origin}#http1-only` dispatcher that legacy global dispatcher consumers, like Node.js' bundled fetch, use. `cleanMocks()` replaced that array, so that dispatcher kept the old interceptors and never saw new ones. Empty it in place instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
metcoder95
approved these changes
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #6013
Rationale
Since #5648,
MockAgentshares a pool'skDispatchesarray with the${origin}#http1-onlydispatcher that legacy global dispatcher consumers (like Node.js' bundledfetch) use.cleanMocks()replaced that array, so the#http1-onlydispatcher kept the old interceptors and never saw new ones.Changes
Features
N/A
Bug Fixes
MockPool.cleanMocks()andMockClient.cleanMocks()empty the interceptors array in place (and reset its total dispatch count) instead of replacing it, so every dispatcher that shares it sees the change.test/node-test/global-dispatcher-version.jsfor both, through Node.js' globalfetch.Breaking Changes and Deprecations
N/A
Status
🤖 Generated with Claude Code