Repository navigation
test: update milo paths in bundle-parser test - #5979
Merged
Merged
Conversation
Milo was vendored as lib/milo/{simd,no-simd}.js in #5954, but #5935
was written against the previous lib/milo/src/*/index.js layout, so the
'ordinary esbuild bundles retain experimental Milo' test fails on main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xf8iHe9HroHgZuP6UXGZnx
Signed-off-by: Matteo Collina <hello@matteocollina.com>
The vendored Milo layout from #5954 has no binary/ or src/ directories. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xf8iHe9HroHgZuP6UXGZnx Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix/bundle-parser-milo-paths
branch
from
October 8, 2026 14:16
436aeb6 to
e23f210
Compare
ShogunPanda
approved these changes
Oct 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5979 +/- ##
==========================================
- Coverage 91.52% 91.52% -0.01%
==========================================
Files 113 113
Lines 43586 43594 +8
==========================================
+ Hits 39894 39901 +7
- Misses 3692 3693 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
ordinary esbuild bundles retain experimental Milotest on main (e.g. https://github.com/nodejs/undici/actions/runs/37787981060/job/113347576882).#5954 vendored Milo as
lib/milo/simd.jsandlib/milo/no-simd.js, but #5935 was written against the previouslib/milo/src/*/index.jslayout, so the test asserted on paths that no longer exist. The bundle-exclusion behavior itself is unaffected; this only updates the asserted paths.node --test test/fetch/bundle-parser.js: 8/8 pass locally.