Skip to content

test: keep the h2c unix socket path within sun_path limits #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
Oct 8, 2026
Merged

test: keep the h2c unix socket path within sun_path limits #5978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/h2c-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,11 @@ test('Connect to h2c server over a unix domain socket', { skip: process.platform
const { join } = require('node:path')
const { tmpdir } = require('node:os')

const tmpDir = await mkdtemp(join(tmpdir(), 'h2c-client-'))
// Unix socket paths are limited to 104 bytes on macOS (108 on Linux), and
// Node.js >= 24 rejects longer ones with EINVAL instead of truncating them.
// os.tmpdir() can be long (e.g. under CITGM on macOS), so fall back to /tmp.
const base = join(tmpdir(), 'h2c-client-XXXXXX', 'server.sock').length < 104 ? tmpdir() : '/tmp'
const tmpDir = await mkdtemp(join(base, 'h2c-client-'))
const socketPath = join(tmpDir, 'server.sock')
const authority = 'localhost'

Expand Down
Loading