Skip to content

fix(http1): reset connections for no-body transfer encoding - #5941

Merged
mcollina merged 1 commit into
mainfrom
fix/h1-no-body-transfer-encoding
Oct 8, 2026
Merged

mcollina merged 1 commit into
mainfrom
fix/h1-no-body-transfer-encoding

Conversation

@mcollina

@mcollina mcollina commented Oct 1, 2026

Copy link
Copy Markdown
Member

Track Transfer-Encoding on HTTP/1.1 responses and avoid reusing a connection after a 204 or 304 response carries it. This extends the existing defensive handling for nonzero Content-Length and prevents trailing bytes from being assigned to a pipelined request.

Adds regression coverage for 204 and 304 responses with both blocking modes.

@codecov-commenter

codecov-commenter commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.52%. Comparing base (c3de472) to head (e208201).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5941   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         113      113           
  Lines       43537    43586   +49     
=======================================
+ Hits        39847    39894   +47     
- Misses       3690     3692    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the fix/h1-no-body-transfer-encoding branch from 0191eab to e208201 Compare October 8, 2026 10:26
@mcollina
mcollina merged commit 384ae67 into main Oct 8, 2026
66 of 67 checks passed
@mcollina
mcollina deleted the fix/h1-no-body-transfer-encoding branch October 8, 2026 13:48
@github-actions github-actions Bot mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants