Repository navigation
fix(http1): reset connections for no-body transfer encoding - #5941
Merged
Merged
Conversation
ronag
approved these changes
Oct 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5941 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 113 113
Lines 43537 43586 +49
=======================================
+ Hits 39847 39894 +47
- Misses 3690 3692 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 of 7 tasks
jasnell
approved these changes
Oct 3, 2026
metcoder95
approved these changes
Oct 8, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
fix/h1-no-body-transfer-encoding
branch
from
October 8, 2026 10:26
0191eab to
e208201
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track
Transfer-Encodingon HTTP/1.1 responses and avoid reusing a connection after a 204 or 304 response carries it. This extends the existing defensive handling for nonzeroContent-Lengthand prevents trailing bytes from being assigned to a pipelined request.Adds regression coverage for 204 and 304 responses with both blocking modes.