Repository navigation
fix: reject unsupported FormData request bodies - #5913
Merged
Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5913 +/- ##
==========================================
+ Coverage 94.04% 94.05% +0.01%
==========================================
Files 110 110
Lines 40252 40267 +15
==========================================
+ Hits 37856 37875 +19
+ Misses 2396 2392 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 26, 2026
metcoder95
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5520.
Rationale
The low-level request path accepted structurally FormData-like bodies, while the multipart serializer only supports FormData created by the current undici package instance. A FormData from Node.js or another undici copy therefore reached body extraction but produced a stream that never emitted, closed, or errored, leaving the request pending indefinitely.
Reject unsupported FormData bodies during request validation, before a connection is opened. This keeps the request validator aligned with the serializer without broadening fetch's FormData compatibility rules.
Changes
InvalidArgumentErrorbefore connection setupFeatures
N/A
Bug Fixes
request()from hanging when passed FormData from another implementationBreaking Changes and Deprecations
FormData from another implementation now rejects immediately. On affected v7 and v8 releases these bodies already failed or hung instead of completing successfully.
Status
Validation:
npm run test:unitnpx borp -p "test/client-request.js"npx borp -p "test/http2-body.js"npm run lint -- --no-cachegit diff --check