Repository navigation
fix(redirect): fix throwOnMaxRedirect edge - #5879
Merged
mcollina merged 1 commit intoSep 24, 2026
Merged
Conversation
When throwOnMaxRedirect is true, and exactly the limit of redirects was hit, the client would throw even if the next response was not a redirect. This fixes it. Signed-off-by: James M Snell <jasnell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 110 110
Lines 39901 39907 +6
=======================================
+ Hits 37470 37476 +6
Misses 2431 2431 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
redirect handling
Rationale
When throwOnMaxRedirect is true, and exactly the limit of redirects was hit, the client would throw even if the next response was not a redirect. See the test.
Spotted while I was working on the other redirect fix.
Changes
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
Status