Skip to content

Error in guide to dockerizing nodejs #1344

Closed
Closed
Error in guide to dockerizing nodejs#1344
Labels
good first issueIssues for newcomers

Description

@rm-rf-etc
rm-rf-etc
opened on Aug 24, 2017

The following instruction, given by the above tutorial, causes a build to fail.
COPY package.json package-lock.json .

The error message reads:

Step 3/7 : COPY ./package.json ./package-lock.json .
When using COPY with more than one source file, the destination must be a directory and end with a /

Activity

  1. pierreneter commented on Aug 24, 2017

    @pierreneter
    pierreneter
    on Aug 24, 2017
    Contributor

    I think it should be COPY package.json package-lock.json ./. can you submit a PR to fix this tutorial?

  2. pierreneter
    added
    docs
    good first issueIssues for newcomers
    on Aug 24, 2017

  3. rm-rf-etc commented on Aug 24, 2017

    @rm-rf-etc
    rm-rf-etc
    on Aug 24, 2017
    ContributorAuthor

    Created pull/1346. Sorry if I missed any aspects of standard protocol.

  4. pierreneter
    added a commit that references this issue on Aug 24, 2017

    Fix instruction in dockerization guide. Issue #1344 (#1346)

    37135a8
  5. pierreneter
    closed this as completedon Aug 24, 2017

  6. pierreneter commented on Aug 24, 2017

    @pierreneter
    pierreneter
    on Aug 24, 2017
    Contributor

    Thanks!

  7. hackygolucky
    added a commit that references this issue on Sep 19, 2017

    Merge branch 'master' of https://github.com/nodejs/nodejs.org

    71683d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions