[Suryanshpandey07]

Expose Brotli decoder error constants using BROTLI_DECODER_ERROR_CODES_LIST instead of manually listing each constant. This avoids compilation errors when building against older shared Brotli libraries (such as Brotli <= 1.2.0) where BROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCH is not yet defined.

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

[Suryanshpandey07]

Context

When building Node.js configured with --shared-brotli against shared Brotli libraries (such as Brotli <= 1.2.0 found in many distributions), the build fails with:

../../src/node_zlib.cc:2271:32: error: use of undeclared identifier 'BROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCH'
 2271 |   NODE_DEFINE_CONSTANT(target, BROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCH);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Solution

Brotli's public header <brotli/decode.h> defines BROTLI_DECODER_ERROR_CODES_LIST as an X-macro intended for iterating over all decoder error codes defined by that header version.

By switching to this macro list:

• The error constants present in whichever Brotli version is included (bundled or shared) are automatically exposed.
• Building against Brotli <= 1.2.0 succeeds without undeclared identifier errors.
• Any future error codes added upstream in Brotli will be exposed automatically.
• The block switch test in test/parallel/test-zlib-invalid-input.js is guarded with a check on zlib.constants.BROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCH !== undefined so test suites run cleanly across shared library versions.