Skip to content

test_runner: forward arguments after -- to test files - #66911

Open
mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:test-runner-forward-argv
Open

mcollina wants to merge 2 commits into
nodejs:mainfrom
mcollina:test-runner-forward-argv

Conversation

@mcollina

Copy link
Copy Markdown
Member

Fixes: #61852

Fixes: nodejs#61852
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina requested a review from cjihrig October 22, 2026 00:47
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 22, 2026
@mcollina mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 22, 2026
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.57%. Comparing base (df2ea49) to head (04e3306).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/runner.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66911      +/-   ##
==========================================
+ Coverage   90.51%   90.57%   +0.05%     
==========================================
  Files         797      797              
  Lines      278252   278515     +263     
  Branches    53472    53545      +73     
==========================================
+ Hits       251868   252268     +400     
+ Misses      16761    16590     -171     
- Partials     9623     9657      +34     
Files with missing lines Coverage Δ
lib/internal/main/test_runner.js 100.00% <100.00%> (ø)
lib/internal/test_runner/runner.js 94.90% <0.00%> (-0.24%) ⬇️

... and 58 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using --test causes process.argv[] to lose user-specified CLI flags

3 participants