Segmentation Fault When Passing Paths with Japanese Characters to createRequire in Node.js 22+Β #56650
Description
Version
v22.13.0
Platform
Microsoft Windows NT 10.0.26100.0 x64
Subsystem
No response
What steps will reproduce the bug?
Create required files
$ New-Item γ.js
$ New-Item γγ.jsCreate main.js
const path = require('path');
const Module = require('module')
const createRequire = Module.createRequire;
// γ.js is fail, but γγ.js is success
const resolved = path.resolve('γ.js');
console.log(resolved);
const req = createRequire(resolved);
// some package...
const result = req.resolve('_');
console.log(result);Run
$ node main.jsHow often does it reproduce? Is there a required condition?
It is always reproduced when Node v22 is used under Windows in a Japanese environment.
Segmentation fault does not occur depending on the file name passed.
Not reproduced in Node v20.
What is the expected behavior? Why is that the expected behavior?
No segmentation fault shall occur.
This is expected to be fixed, since tools such as eslint cannot be used if files containing Japanese characters exist, since the same processing as the reproduced code is performed inside eslint.
What do you see instead?
No output
Additional information
It's repro repository.
https://github.com/yamachu/node-require-japanese-repro
And
Node 22.2.0 Passed
Node 22.3.0 Failed
https://nodejs.org/download/nightly/v23.0.0-nightly20240521786cb42956/ is Passed
https://nodejs.org/download/nightly/v23.0.0-nightly202405224a54a80aa3/ is Failed
Activity
yamachu commentedon Jan 18, 2025
I have confirmed that the following changes will be processed as intended in the SJIS(cp932) environment.
However, we have not been able to determine the extent of the impact of using locale::global in the node runtime and ignoring the original locale....
yamachu@30fc150
yamachu commentedon Jan 19, 2025
node/src/node_modules.cc
Lines 347 to 348 in 009d53e
I followed it in the debugger and it seems to throw an exception when creating this path object.
src: fix to generate path from wchar_t via wstring
test: add test that uses multibyte for path and resolves modules
test: add test that uses multibyte for path and resolves modules
src: fix to generate path from wchar_t via wstring
src: fix to generate path from wchar_t via wstring
test: add test that uses multibyte for path and resolves modules
test: add test that uses multibyte for path and resolves modules
src: fix to generate path from wchar_t via wstring
test: add test that uses multibyte for path and resolves modules
src: fix to generate path from wchar_t via wstring
test: add test that uses multibyte for path and resolves modules
src: fix to generate path from wchar_t via wstring
test: add test that uses multibyte for path and resolves modules
src: fix to generate path from wchar_t via wstring