Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options

Version

v18.18.2

Platform

Darwin 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000 arm64

Subsystem

n/a

What steps will reproduce the bug?

n/a

How often does it reproduce? Is there a required condition?

n/a

What is the expected behavior? Why is that the expected behavior?

n/a

What do you see instead?

Options are not preserved when instantiating a new Fetch Request object using a Request as the first parameter. This causes the options, that should have been copied, to be missing on the new Fetch Request object.

This behavior was fine on <= Node v18.18.1. It is broken on Node v18.18.2.

this.request = new globalThis.Request(this.request, {body: this._options.body});

The options fail to be copied. Is this the new expected behavior of the Request constructor after the patch?

See: https://github.com/nodejs/node/releases/tag/v18.18.2
See: sindresorhus/ky#535
See: https://github.com/sindresorhus/ky/blob/d372e2eccf9f47597f2c0f49cba286e19d7974b3/source/core/Ky.ts#L203

Additional information

May be related to latest CVE fixes.

Has anyone taken this issue?

I am seeing the same behavior in Node v20.8.1 (the analogous security release for the v20 line).

reproducible by the following code, but works properly in undici.

const request = new Request('https://a', {
  headers: {
    'test': 'abc'
  },
  method: 'POST'
})

const request1 = new Request(request, { body: 'abc' })

console.log(request1.headers.get('test')) // should be 'abc', is null

this will be fixed by the next undici update (cc @nodejs/undici)

@KhafraDev

@KhafraDev what PR is this fixed in?

I believe it's nodejs/undici#2359

I have no idea, I only had time to test if the new bundle fixed the issue, which it did.

Same issue here right now with both Node 18.8.2 and 21.0.0 ⚠️
All request headers are absolutely empty 💀 all the time in test cases, when fetch is used 🥶
Seems like a catastrophic bug 🪲 and needs an emergency 🚑 hotfix, asap 😱

Repro script:

import { rest } from 'msw';
import { setupServer } from 'msw/node';
import assert from 'node:assert/strict';

const url = 'https://somewhe.re/somewhat/endpoint';

const server = setupServer(
  rest.get(url, (req, res, ctx) => {
    const headers = [...req.headers];

    console.info(headers); // Will be empty []
    assert(headers.length, 'Headers should not be empty'); // Will throw here

    return res(ctx.status(200));
  }),
);

await server.listen();

await fetch(url, {
  headers: {
    'accept': 'application/json',
    'authorization': 'Bearer <token>',
  },
});

await server.close();

Can you reproduce without msw?

I posted a reproduction above

Is it true that once #50274 lands that this issue will be resolved?

I don't see anything in the release notes for undici@5.26.4 that seems directly related to this issue. Can anyone provide a status update?

Nothing related to 5.26.3 should have broken this either, it's a strange issue.

@KhafraDev

@KhafraDev could you send a PR with the regression test so we don't break this anymore?

It might be nice to run the entirety of the fetch tests on the bundle, rather than adding in a useless test. Or maybe we could figure out a way to not bundle undici, which would prevent all of these issues from happening (including the issue regarding names recently).

This issue shouldn't be closed as the problem still persists in the newly released 20.9.0 as well as the as-of-now current 18.18.2 listed in the issue title

@KhafraDev

@KhafraDev can you send a PR with a regression test on Node.js for this?

add regression test

add regression test (#2376)

@MajorTanya

Hello all, can someone provide a status update on this issue? As @MajorTanya stated, this issue is not resolved in the 20.9.0 release.

@mattcollier

@mattcollier #50274 has comments about the fix being cherry-picked into v18.x-staging and v20.x-staging.

Hey all!
Any update on this, when can we expect a release containing the fixes?

Not a contributor, but this seems to be fully fixed with the 20.10.0 LTS release

Edit: due to the lack of a new release for 18.x at this point, this remains an issue for 18.18.2

With 18.19.0 landing in 8787acb, this issue should be resolved across v18, v20, and v21, which are all supported versions.

add regression test (nodejs#2376)

Navigation Menu

Repository navigation

Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

10 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

justinbather commented on Oct 18, 2023

BrettHoutz commented on Oct 18, 2023

KhafraDev commented on Oct 19, 2023

KhafraDev commented on Oct 19, 2023

mcollina commented on Oct 19, 2023

targos commented on Oct 19, 2023

KhafraDev commented on Oct 19, 2023

bricss commented on Oct 19, 2023

bricss commented on Oct 19, 2023

mcollina commented on Oct 19, 2023

KhafraDev commented on Oct 19, 2023

mattcollier commented on Oct 19, 2023

KhafraDev commented on Oct 19, 2023

10 remaining items

KhafraDev commented on Oct 20, 2023

MajorTanya commented on Oct 24, 2023

mcollina commented on Oct 25, 2023

mattcollier commented on Oct 26, 2023

davidlehn commented on Oct 26, 2023

johndalvik commented on Nov 7, 2023

MajorTanya commented on Nov 24, 2023

MajorTanya commented on Nov 29, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions