You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fs: utf8 fast paths don't accept all valid utf8 values #49888
I don't think that would be needed, there's only 4 cases where that returns utf8 and it's with the values: utf8, utf-8, UTF8, UTF-8. It might be worth making a small util to check for those (not sure if the function call would add overhead or not).
Oh right as a final check. I don't think fast paths should have to worry about that for now at least as I doubt it's common and would add measurable overhead?
I once wrote for testing all permutations of uppercase/lowercase into a Map and it improved the performance of normalizeEncoding. This sounds like a use case for normalizeEncoding.
i think that it is special character if you file name are file_name emoji.txt are not valid . correct way your file name without any emoji are better way.
Hello everyone, I'm making an effort to start contributing to the project, and I would like to know if anyone knows if the current open PR's are already "on their way to merge" or if this issue still has space to be worked on.
#62304 and #60539 seem to be "accepted" by some members, but it also looks like there is a dependent issue that affects CI that needs to be merged before they do. cc @ChALkeR (Sorry for the mention, it seems like you are not tagged into this issue, but you are involved in one of the PR's, so it feels right to include you here)
I'm reading the contribution material and trying to get a feel of how the issues and contributions work, and I would appreciate any guidance.
This issue has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
Activity
Uzlopak commentedon Sep 27, 2023
Seems there needs to be a call to normalizeEncoding
CanadaHonk commentedon Sep 27, 2023
I don't think that would be needed, there's only 4 cases where that returns
utf8and it's with the values:utf8,utf-8,UTF8,UTF-8. It might be worth making a small util to check for those (not sure if the function call would add overhead or not).Uzlopak commentedon Sep 27, 2023
yeah, but you could also have mixed cases, like 'Utf-8' right?
CanadaHonk commentedon Sep 27, 2023
Oh right as a final check. I don't think fast paths should have to worry about that for now at least as I doubt it's common and would add measurable overhead?
Uzlopak commentedon Sep 27, 2023
I once wrote for testing all permutations of uppercase/lowercase into a Map and it improved the performance of normalizeEncoding. This sounds like a use case for normalizeEncoding.
BridgeAR commentedon Sep 12, 2025
I marked this as good first issue since the handling should easy to unify.
salman-aziz-4425 commentedon Sep 17, 2025
@BridgeAR, @CanadaHonk Can I take this as a good first issue?
HishamHR5 commentedon Oct 7, 2025
@BridgeAR , @CanadaHonk , if this issue is still open ,can I take this as a good first issue?
shivam1234tiwari commentedon Mar 17, 2026
i think that it is special character if you file name are file_name emoji.txt are not valid . correct way your file name without any emoji are better way.
fs: accept all valid UTF-8 encoding names in fast paths
fs: normalize encoding before utf8 fast path check
luanmuniz commentedon Jun 5, 2026
Hello everyone, I'm making an effort to start contributing to the project, and I would like to know if anyone knows if the current open PR's are already "on their way to merge" or if this issue still has space to be worked on.
#62304 and #60539 seem to be "accepted" by some members, but it also looks like there is a dependent issue that affects CI that needs to be merged before they do. cc @ChALkeR (Sorry for the mention, it seems like you are not tagged into this issue, but you are involved in one of the PR's, so it feels right to include you here)
I'm reading the contribution material and trying to get a feel of how the issues and contributions work, and I would appreciate any guidance.
icecold009 commentedon Jun 21, 2026
Hi, I’d like to work on this as my first contribution to Node.js. Is this still available?
shivam1234tiwari commentedon Jul 8, 2026
yes
efekrskl commentedon Jul 9, 2026
Removing
good first issueas we received several PRs, and one of them has a few approvalsgithub-actions commentedon Oct 8, 2026
This issue has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.