Repository navigation
Allow napi_add_finalizer to work on primitive types #48311
Description
What is the problem this feature will solve?
We may want to have feature parity with napi_create_reference, since, internally, both create a reference.
@nodejs/node-api WDYT?
What is the feature you are proposing to solve the problem?
Open up napi_add_finalizer to primitive types.
What alternatives have you considered?
No response
Activity
gabrielschulhof commentedon Jun 3, 2023
@vmoroz WDYT?
toyobayashi commentedon Jun 4, 2023
Finalizers are implemented via
FinalizationRegistryin browser, but primitive types can not work withFinalizationRegistry. When should the finalizer associated with primitive value be called?gabrielschulhof commentedon Jun 5, 2023
@toyobayashi V8 has support for weak references to primitive types. @vmoroz implemented support for such weak references in #45715 for
napi_create_reference(). I'm proposing we similarly loosen restrictions from objects-only to objects and primitive types innapi_add_finalizer().vmoroz commentedon Jun 5, 2023
@gabrielschulhof , I am curious how it could be implemented for the primitive types:
napi_refis deleted. It will have a different semantic as it will not necessarily mean that the underlying V8 object is deleted.Do you know if V8 supports calling finalizers for primitive types?
toyobayashi commentedon Jun 6, 2023
@gabrielschulhof yes I know the implementation detail of #45715 and toyobayashi/emnapi#64 implemented it. I'm not sure if adding finalizer to primitive types could be implemented in emnapi, even if v8 supports, emnapi can't access v8 API, it relies on
FinalizationRegistryto call finalizers. HoweverFinalizationRegistrydoesn't work on primitive types, so I asked when the finalizer should be called.gabrielschulhof commentedon Jun 8, 2023
Oh, I see now. References can be created for primitive types, but not weak ones.