Repository navigation
Computed props are not properly handled #2507
Description
Repost of microsoft/TypeScript#4419
Seems like this problem is related to v8. Following code (using iojs@3.1)
var prop = 'age'
var val = 42
console.log([{ name: "ivan", [prop]: val }])
console.log({ name: "ivan", [prop]: val })produces output
[ { name: 'ivan' } ]
{ name: 'ivan', age: 42 }
Activity
Fishrock123 commentedon Aug 23, 2015
Weird that the bottom works but the top doesn't. @ofrobots?
mscdex commentedon Aug 23, 2015
FWIW same issue exists in
next+1/v8 4.5[-]Computed pops are not properly handled[/-][+]Computed props are not properly handled[/+]ofrobots commentedon Aug 23, 2015
I see the same behaviour in Chrome 44 and Chrome Canary (V8 4.6). @lazutkin Do you want to open a V8 issue here: https://code.google.com/p/v8/issues/list
lazdmx commentedon Aug 23, 2015
Ok. Will do.
Fishrock123 commentedon Aug 23, 2015
Closing, nothing io.js itself can do. :)
lazdmx commentedon Aug 24, 2015
Ref: https://code.google.com/p/v8/issues/detail?id=4387
rvagg commentedon Aug 24, 2015
We're going in to LTS with this version of V8, I hope this isn't going to bite us in a similar way to
Array.values()in 0.12, perhaps this should be part of our "Known issues"?Fishrock123 commentedon Aug 24, 2015
Yeah perhaps we should document it. It's not a thing that perviously existed though (afaik) so I think we're good there.
mgol commentedon Aug 25, 2015
This seems worrying, especially that it's available by default, not behind a flag. Comments in the V8 issue suggest the fix for that will be a one-liner. I somehow missed that Node 4.0.0 will use v8 4.4, not 4.5 (i.e. the same as io.js 3) but since v8 4.4 will soon lose upstream support perhaps patching this on the Node.js side wouldn't introduce big issues?
rvagg commentedon Aug 26, 2015
I'd not be opposed to floating a patch on v8 for this when they drop support for 4.4 upstream because we're going to have to be supporting this version for some time and will be adding our own patches to it anyway. I don't see this as being a huge problem, at least initially, but perhaps as folks start using computed properties for newer versions of node and v4 LTS starts to get a bit old we could end up in hot water.
Fishrock123 commentedon Aug 26, 2015
I'm fine with just leaving a note about it I think.
11 remaining items
deps: upgrade V8 to 4.5.103.33
rvagg commentedon Sep 15, 2015
addressed by #2870
deps: upgrade V8 to 4.5.103.33
deps: upgrade V8 to 4.5.103.33
brendanashworth commentedon Sep 17, 2015
The fix landed in 704dcce and was released in 4.1.0, closing.
use newer node version (#49)
Update to 4.0.0
Update to 4.0.0