Repository navigation
Run the internet tests on CI from time to time? #13061
Description
Ideas for making this happen:
- Run them when cutting a release? @nodejs/release
- Run them once a day on CI, perhaps as part of the node-daily-master job? @nodejs/build
That's all I have so far.
/cc @nodejs/testing
Activity
cjihrig commentedon May 16, 2017
+1 to running them once a day.
targos commentedon Sep 3, 2017
Ping. Did anything happen to resolve this?
Trott commentedon Jun 3, 2018
Since we're talking about running debug tests nightly, and/or tests with
--gc-intervalnightly, I guess this is a good time to raise the profile of this request too. @nodejs/buildmaclover7 commentedon Jun 3, 2018
Wasn't too hard to setup, 18/21 tests are passing: https://ci.nodejs.org/job/node-test-commit-custom-suites/6/
Trott commentedon Jun 3, 2018
Awesome, thanks!
The two dgram failures may be making assumptions about network configuration that aren't true on our CI hosts. I can try to mess around with those a bit to see what might be done.
The dns failure is a straight up failing test that we just haven't noticed until now because we don't run the internet tests ever. :-D I'll take a look at that one too.
Trott commentedon Jun 3, 2018
PR to fix dns test: #21116
maclover7 commentedon Jul 12, 2018
Looks like all
internettests are passing now -- should this be added ontonode-daily-masterruns?Trott commentedon Jul 12, 2018
The results say that
internet/test-inspector-help-pageis being skipped because it is being run inside a worker. That can't be right, can it? Is this a bug somehow incommon.skipIfInspectorDisabled()/common.isMainThread()/worker_threads.isMainThread?/cc @addaleax
Trott commentedon Jul 12, 2018
Aside from the worker_threads question above, I'm 👍 on moving to node-daily-master!
Trott commentedon Jul 12, 2018
The inspector test runs fine on my computer and is not skipped, so I'm guessing either the possible bug is OS-specific or else there is no bug and we really are running it in a worker thread?
addaleax commentedon Jul 12, 2018
@Trott Yes, looks like that’s what’s happening:
But then again
--workerwas also passed in asTEST_ARGSin the UI, it seems?Trott commentedon Jul 12, 2018
Ah, OK, yeah, I can emulate the skipping on my machine with those command line options. Should have pulled that from the console in the first place. Sorry/thanks!
@maclover7 Running the tests locally without
--worker, they all pass and that one that currently gets skipped is not skipped anymore. Any chance we can make that change?maclover7 commentedon Jul 12, 2018
Ah, forgot that
--workeris a default argument for the job. Re-ran without the arg, all tests seem to pass still.Is there any advantage (since the job only takes ~2 minutes) to running once with
--worker, and once without?addaleax commentedon Jul 12, 2018
@maclover7 I don’t think there’s any particular benefit to running the internet tests in those configurations … we should keep going on nodejs/build#1318 to get
--workersupport intonode-test-commitand then we don’t really need to worry about it for other jobs anymoremaclover7 commentedon Jul 15, 2018
First run of node-daily-master with the internet tests is all green 🎉🎉🎉 https://ci.nodejs.org/job/node-daily-master/1221/