You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Async function execute in different version got different output about async function itself #1733
When I use the 10.15.0 version, I got two different outputs.
This does not appear on the 11.7.0 version.
I did not find the relevant modification record on the ChangeLog.
I'm not sure if it is a bug fix, or an implementation change. Can you provide the corresponding information?
I'm more interested in this, thank you.
I did bisect and landed with this PR: nodejs/node#22390
I'm not sure whether this is a bug or Enhancement. Copying the author to get more insight.
cc @TimothyGu
I did more research on this. This bisects to nodejs/node@0e7ddbd (brought by PR nodejs/node#22754). Further bisecting V8 revealed that the bug is fixed in v8/v8@4ef4dea, as a special case of v8/v8#5085. The relevant test, which is basically the same script from the OP, that was added in that commit is test-regress-5085.
Activity
vsemozhetbyt commentedon Jan 23, 2019
On Windows 7 x64:
vsemozhetbyt commentedon Jan 23, 2019
cc @nodejs/v8
Hakerh400 commentedon Jan 25, 2019
Seems like it was a bug in old V8.
There's no semantical difference between the last two lines, but they give different results.
yathamravali commentedon Jan 31, 2019
I did bisect and landed with this PR:
nodejs/node#22390
I'm not sure whether this is a bug or Enhancement. Copying the author to get more insight.
cc @TimothyGu
TimothyGu commentedon Jan 31, 2019
@yathamravali The referenced PR was later reverted: nodejs/node#22911. So it couldn’t have been that.
TimothyGu commentedon Jan 31, 2019
@Hakerh400’s analysis seems correct though.
gireeshpunathil commentedon Jun 18, 2019
closing as answered, let me know if there is anything outstanding here
Hakerh400 commentedon Jul 26, 2019
I did more research on this. This bisects to nodejs/node@0e7ddbd (brought by PR nodejs/node#22754). Further bisecting V8 revealed that the bug is fixed in v8/v8@4ef4dea, as a special case of v8/v8#5085. The relevant test, which is basically the same script from the OP, that was added in that commit is test-regress-5085.