You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The overall linting and formatting rules in Corepack is extremely different than other repositories in Node.js. I'm planning on replacing it with Biome (which comes with linter and formatter) and have more nodejs/node similar code styles.
It should use the same linter and lint rules as the Node core repo. Then if we ever move Corepack into the core repo, the code would already pass the lint check.
Then get Biome used on the main repo first, then update this one. If the main repo never migrates to Biome then we’re not any better off after migrating this repo to Biome than we are today.
We’re not any worse, either, I suppose. So either way. But it would be wasted effort if we migrate this to Biome and then the main repo migrates to something else, and then this repo needs to migrate again to that something else.
Activity
GeoffreyBooth commentedon Feb 27, 2024
It should use the same linter and lint rules as the Node core repo. Then if we ever move Corepack into the core repo, the code would already pass the lint check.
aduh95 commentedon Feb 27, 2024
See nodejs/node-core-test#22 for what would need to happen for this to be possible. The effort was started in nodejs/eslint-plugin-nodejs-internal#1
anonrig commentedon Feb 27, 2024
@GeoffreyBooth I recommended Biome because of several reasons:
anonrig commentedon Feb 27, 2024
I personally prefer to not invest more time on the current solution and Eslint, in favor of nodejs/node#50672
GeoffreyBooth commentedon Feb 27, 2024
Then get Biome used on the main repo first, then update this one. If the main repo never migrates to Biome then we’re not any better off after migrating this repo to Biome than we are today.
We’re not any worse, either, I suppose. So either way. But it would be wasted effort if we migrate this to Biome and then the main repo migrates to something else, and then this repo needs to migrate again to that something else.
merceyz commentedon Feb 27, 2024
That seems like a negative and prone to bikeshedding.