Repository navigation
Compilation broken on Windows with VS 17.12 #3963
Description
VS 2022 v17.12 (released Nov 12) cannot compile Node.js with MSVC. I'm working on making a simple reproduceable example to open an issue in developercommunity.visualstudio.com.
cc @nodejs/platform-windows
Refs: #3739
Metadata
Metadata
Assignees
Labels
No labels
Activity
StefanStojanovic commentedon Nov 19, 2024
Here is the developer community issue.
build: avoid compiling with VS v17.12
build: avoid compiling with VS v17.12
build: avoid compiling with VS v17.12
Flarna commentedon Nov 28, 2024
Received 17.12.2 today and it seems problem is fixed there.
Revert "build: avoid compiling with VS v17.12"
targos commentedon Dec 8, 2024
nodejs/node#56151 Landed so I've re-enabled the Windows workflows.
StefanStojanovic commentedon Dec 9, 2024
I plan to unpin Visual Studio version in our CI machines and will close this issue once that is done.
Revert "build: avoid compiling with VS v17.12"
StefanStojanovic commentedon Dec 12, 2024
I've updated VS versions to the latest on all test and release CI machines. Will follow it for a few days and close if all is OK.
StefanStojanovic commentedon Dec 16, 2024
Closing since all is alright in the CI.