This repository was archived by the owner on Feb 29, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 29, 2020. It is now read-only.
Investigate FS and other codepage dependencies #25
Description
In nodejs/node#3401 it's discussed that almost all fs functions assume a Unicode-supporting filesystem, specifically, that char* are in UTF-8. While this is somewhat common (and an ideal) picture, it's not universal. Consider how to work with this issue:
- should libuv and/or calls to it detect the encoding and convert?
- … with a fast path for environments (OS X, Windows, others?) with a known encoding
Activity
bnoordhuis commentedon Oct 24, 2015
Libuv treats path names as byte arrays (except on Windows) so I don't think libuv is the right place to do conversion, that logic should go into the "representation layer", i.e., node.js.
There is no platform-specific known encoding, it depends on the file system. Libuv probably needs to grow a statvfs(2) binding that lets node.js decide what file system it's dealing with on a per-path basis.
srl295 commentedon Oct 27, 2015
nodejs/node#3519
srl295 commentedon Apr 3, 2018
^ closing due to above