Repository navigation
'async' modifier cannot be used in an ambient context.ts #36989
Description
TypeScript Version: 3.8.2
Search Terms: allowJs declaration 'async' modifier cannot be used in an ambient context.ts
Code
see code
when run tsc with allowJs and declaration flags enabled the code below
export class TestJS {
callAsync() {
return Promise.resolve(1);
}
async test() {
await this.callAsync();
}
}produce the declaretion:
export class TestJS {
callAsync(): Promise<number>;
async test(): Promise<void>; --> error
}but when a try to use this class I receive 'async' modifier cannot be used in an ambient context.ts(1040)
Expected behavior:
the TestJS.d.ts shouldn't contain async
Actual behavior:
TestJS.d.ts conteins async
Playground Link: code
Related Issues:
Activity
pocesar commentedon Feb 25, 2020
was going to post about this right now, the behavior from JS / TS is definitely off
DanielRosenwasser commentedon Feb 25, 2020
Tests should probably include a test for generators too.
francesc79 commentedon Feb 25, 2020
with typescript 3.7.5 work well
DanielRosenwasser commentedon Feb 25, 2020
Seems like this is fixed in the nightlies. Wesley Wigham (@weswigham) can you verify, track down the fix, and cherry-pick it?
chore: pin typescript to 3.7.x
chore: pin typescript to 3.7.x
a-tarasyuk commentedon Feb 26, 2020
This issue related to the method
makeSerializePropertySymbol. In the3.8.*(need to find the commit where it was done) was added the way to get the modifier flagsconst modifierFlags = getDeclarationModifierFlagsFromSymbol(p);of a symbol and use these flags to create nodes. The3.7.*handles only static modifierconst staticFlag = isStatic ? ModifierFlags.Static : 0;- that's why3.7.*doesn't emitasyncmodifier.cc Daniel Rosenwasser (@DanielRosenwasser) Wesley Wigham (@weswigham) zazos (@francesc79)
weswigham commentedon Feb 27, 2020
Oleksandr Tarasiuk (@a-tarasyuk) it regressed in #35731 probably, since prior to that we weren't pulling on "original" modifier flags from anywhere.
Looks broken in the nightlies to me
Update TypeScript to 3.8.3
Update TypeScript to 3.8.3