Repository navigation
test(utils): make keepalive tests pass on macOS - #2749
Open
ArfiArfath21 wants to merge 1 commit into
Open
ArfiArfath21 wants to merge 1 commit into
ArfiArfath21 wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArfiArfath21 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
ArfiArfath21
force-pushed
the
keepalive-tests-macos
branch
from
October 16, 2026 18:17
ef179e4 to
ddedb1f
Compare
Author
|
/easycla |
The tests referenced socket.TCP_KEEPIDLE, which macOS does not define (it uses TCP_KEEPALIVE; keepalive.py already handles this), and expected SO_KEEPALIVE to read back as exactly 1, but macOS returns a non-zero flag.
ArfiArfath21
force-pushed
the
keepalive-tests-macos
branch
from
October 16, 2026 18:23
ddedb1f to
85cf84c
Compare
Author
|
/easycla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
kubernetes/utils/keepalive_test.pyfailed on macOS: it referencedsocket.TCP_KEEPIDLE, which macOS does not define (it usesTCP_KEEPALIVE;keepalive.pyalready handles that), and expectedgetsockopt(SO_KEEPALIVE)to read back as exactly1while macOS returns a non-zero flag (8). The tests now resolve the idle option the same waykeepalive.pydoes, skip when the platform has neither, and assert a non-zero value for the boolean option. No library code changes.Which issue(s) this PR fixes:
Related to #2747 (test-only change, so not using
Fixes).Special notes for your reviewer:
On macOS, 3 of 11 tests in this file failed on
masterand all 11 pass with this change. Behaviour on Linux is unchanged.AI assistance disclosure: prepared with Claude Code; I reviewed the change and ran the tests locally.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: