Repository navigation
Fix SUBSTITUTE expanding dollar sequences in replacement text - #1809
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
|
@vera-rubin Thank you very much for taking the time to prepare the pull request. There's one thing holding us back from using those changes in production — could you please sign the CLA: https://cla.handsontable.com/sign?pr=handsontable%2Fhyperformula%231809 |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
@vera-rubin Thank you for signing the CLA! The status check has been updated and your pull request is now unblocked. 🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When we omit
occurrence,SUBSTITUTEinterprets dollar sequences innew_textas JavaScript replacement patterns. We now return replacement text from a callback so it's inserted literally.How did you test your changes?
We added a regression test and ran the public Jest suite, CommonJS build, and lint.
Types of changes
Related issues:
Fixes #1808
Checklist:
— ChipLab