Skip to content

Fix SUBSTITUTE expanding dollar sequences in replacement text - #1809

Open
vera-rubin wants to merge 1 commit into
handsontable:masterfrom
vera-rubin:fix/substitute-literal-replacement
Open

vera-rubin wants to merge 1 commit into
handsontable:masterfrom
vera-rubin:fix/substitute-literal-replacement

Conversation

@vera-rubin

Copy link
Copy Markdown

Context

When we omit occurrence, SUBSTITUTE interprets dollar sequences in new_text as JavaScript replacement patterns. We now return replacement text from a callback so it's inserted literally.

How did you test your changes?

We added a regression test and ran the public Jest suite, CommonJS build, and lint.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1808

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

— ChipLab

@cla-external-contractor-signup

Copy link
Copy Markdown

@vera-rubin Thank you very much for taking the time to prepare the pull request. There's one thing holding us back from using those changes in production — could you please sign the CLA: https://cla.handsontable.com/sign?pr=handsontable%2Fhyperformula%231809
Thanks in advance 🙇

@cursor

cursor Bot commented Oct 14, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@cla-external-contractor-signup

Copy link
Copy Markdown

@vera-rubin Thank you for signing the CLA! The status check has been updated and your pull request is now unblocked. 🎉

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SUBSTITUTE expands dollar sequences in replacement text

1 participant