Repository navigation
fix(dev): default adk.web.cors.origins to same-origin only instead of * - #1668
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…of `*` - Applies to the REST API and the `/run_live` WebSocket. The bundled dev UI is same-origin and needs no configuration. - A UI served from another origin now needs `adk.web.cors.origins`, for example `adk.web.cors.origins=http://localhost:4200`. - Behind a reverse proxy, a request whose origin matches the URL in the proxy's `Forwarded` header, or its `X-Forwarded-*` headers when `Forwarded` is absent, counts as same-origin. A proxy that hides the external scheme, host or non-default port needs `adk.web.cors.origins`. PiperOrigin-RevId: 997788515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(dev): default
adk.web.cors.originsto same-origin only instead of*/run_liveWebSocket. The bundled dev UI is same-origin and needs no configuration.adk.web.cors.origins, for exampleadk.web.cors.origins=http://localhost:4200.Forwardedheader, or itsX-Forwarded-*headers whenForwardedis absent, counts as same-origin. A proxy that hides the external scheme, host or non-default port needsadk.web.cors.origins.