Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/untrusted-checkout/mediumreports a reusable workflow that checks out its own source:The
job.workflow_*context properties identify the workflow file that defines the running job, so this checkout fetches the code that is already running. GitHub's documentation uses this same step as its example for these properties.When a reusable workflow has no caller in the analyzed repository, its trigger event is unknown, and
GitHubEventJsonSourcetreats every expression in it as untrusted. This change excludesjob.workflow_ref,job.workflow_sha,job.workflow_repositoryandjob.workflow_file_pathfrom that case.I added
reusable_workflow_self_checkout.ymlto the CWE-829 query tests; it produces no results. All tests underactions/ql/testpass with CodeQL CLI 2.27.3.