Repository navigation
Unified: flow summaries - #22809
Draft
asgerf wants to merge 51 commits into
Draft
Unified: flow summaries#22809asgerf wants to merge 51 commits into
asgerf wants to merge 51 commits into
Conversation
There are two interfaces that both need to be shielded from technical details and breaking changes: the language plugin, and the public API. The interface to the language plugin is now called BuilderNode and largely looks and feels the same as the public API, but with some differences, e.g: - It needs to be evaluated at an earlier stage - We might be more willing to expose entities like DataFlowCallable - asExpr() is unavailable in BuilderNode as it's a footgun in that area
Since the callee itself is now always considered to be an argument, it needs to have a post-update node. This only matters when the callee is a function with captures, but it should be harmless in general.
This appeared after an LLM-assisted rebase
Model flow through the "weak" operator we insert in the AST mapping
To avoid alert wobbles we want to match the original alert location. For now just keep track of which alerts have moved.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.