Repository navigation
Conversation
h3xds1nz
reviewed
Sep 29, 2026
| DUCE.CopyBytes((byte*)&data.StartAngle, (byte*)&tempStartAngle, 8); | ||
| data.hStartAngleAnimations = hStartAngleAnimations; | ||
| double tempEndAngle = EndAngle; | ||
| DUCE.CopyBytes((byte*)&data.EndAngle, (byte*)&tempEndAngle, 8); |
Member
There was a problem hiding this comment.
You wouldn't want to use CopyBytes in 2016+ code over a simple assignment.
I understand which file it came from, so just saying 😀
Contributor
Author
There was a problem hiding this comment.
Yeah I tried to match the existing code as much as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SweepGradientBrush, see API proposal #11962
Description
This is a new brush required by COLRv1 fonts.
Testing
Tested locally, but I don't want to finalize this without DRT against Direct2D reference.
The angle follows WPF convention of being clock-wise, which is the opposite of OpenType. Some degenerate cases also lean towards consistency with other WPF brushes rather than OpenType spec. The code building geometry from fonts is expected to create the brush as appropriate.
Microsoft Reviewers: Open in CodeFlow