Repository navigation
Conversation
GenericsHelpers.MethodWithSlotAndModule and ClassWithSlotAndModule are looked up by name in the runtime to build dictionary lookup helpers, so they have no CorInfoHelpFunc entry and were not rooted by ReadyToRunJitHelperRootProvider. On Wasm there is no JIT to fall back on. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericsHelpers.MethodWithSlotAndModuleandGenericsHelpers.ClassWithSlotAndModuleare looked up by name in the runtime (DynamicHelpers::GetDictionaryLookupHelper) to build generic dictionary lookup helpers, so they have noCorInfoHelpFuncentry andReadyToRunJitHelperRootProvidernever rooted them. As a result they were not compiled into R2R builds of System.Private.CoreLib. On Wasm there is no JIT to fall back on.This adds a second list of runtime-looked-up managed helpers to
ReadyToRunJitHelperRootProviderand roots them through the same path as the existing helpers.GenericsHelpers.MethodandGenericsHelpers.Classwere already rooted.I audited the other
DYNAMICJITHELPERentries injithelpers.h, and all of them were already rooted.Validation:
ILCompiler.ReadyToRunbuilds. I also verified with a temporary test (not included in this PR) that compiled CoreLib with unrooted inputs for the browser-wasm target. It failed withExpected compiled method 'System.Runtime.CompilerServices.GenericsHelpers.MethodWithSlotAndModule' not foundwithout this change, and passed with it. I did not run it for x64 or x86.Resolves #135346
Note
This PR description was AI/Copilot-generated.