Repository navigation
acc: Clean up and reject EnvMatrix.DATABRICKS_BUNDLE_ENGINE - #7136
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 11 changed tests (limit=20, 0 not selected) 13 tests: regression=0 unreleased=1 coverage=12 failing=0
TestAccept/ssh/connect-serverless-feature-disabled: branch ✅ | main (e5cdfb9) ✅ | latest (v1.22.1) ❌latest (v1.22.1): |
Collaborator
Integration test reportCommit: f0fd02e
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 21, 2026 14:56
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 21, 2026 14:56
denik
force-pushed
the
denik/remove-databricks-bundle-engine
branch
from
October 21, 2026 14:59
ab689d4 to
b6eb4d2
Compare
janniklasrose
approved these changes
Oct 21, 2026
denik
enabled auto-merge
October 21, 2026 15:02
The direct engine is the only engine, so pinning it in EnvMatrix does nothing. Remove the leftover pins and fail tests that add one. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/remove-databricks-bundle-engine
branch
from
October 23, 2026 09:54
b6eb4d2 to
34a6345
Compare
…anager Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The direct engine is the only engine since the Terraform removal, so pinning
EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["direct"]does nothing.Changes
Remove the 9 leftover pins and fail any acceptance test that sets this key in
EnvMatrix(Envis still allowed).