Skip to content

acc: Clean up and reject EnvMatrix.DATABRICKS_BUNDLE_ENGINE - #7136

Merged
denik merged 3 commits into
mainfrom
denik/remove-databricks-bundle-engine
Oct 23, 2026
Merged

denik merged 3 commits into
mainfrom
denik/remove-databricks-bundle-engine

Conversation

@denik

@denik denik commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Why

The direct engine is the only engine since the Terraform removal, so pinning EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["direct"] does nothing.

Changes

Remove the 9 leftover pins and fail any acceptance test that sets this key in EnvMatrix (Env is still allowed).

@github-actions github-actions Bot added the DABs DABs related issues label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Commit: f0fd02e49 | Workflow run

Regression test report

Selected 11 changed tests (limit=20, 0 not selected)

13 tests: regression=0 unreleased=1 coverage=12 failing=0

test branch main (e5cdfb9) latest (v1.22.1)
TestAccept/apps/validate ✅ ✅ ✅
TestAccept/apps/validate-package-manager ✅ ✅ ✅
TestAccept/bundle/deployment/bind/job/unreadable-state/DMS= ✅ ✅ ✅
TestAccept/bundle/environments/project_environment/DMS= ✅ ✅ ✅
TestAccept/bundle/environments/project_environment/DMS=true ✅ ✅ ✅
TestAccept/bundle/sync-upload-edge-cases/DMS= ✅ ✅ ✅
TestAccept/bundle/sync-upload-edge-cases/DMS=true ✅ ✅ ✅
TestAccept/bundle/templates/app-appkit/DMS= ✅ ✅ ✅
TestAccept/cmd/apps/init/package_manager ✅ ✅ ✅
TestAccept/cmd/apps/init/package_manager_prune ✅ ✅ ✅
TestAccept/pipelines/history/basic ✅ ✅ ✅
TestAccept/ssh/connect-serverless-feature-disabled ✅ ✅ ❌
TestAccept/ssh/connect-serverless-port-forwarding-disabled ✅ ✅ ✅
TestAccept/ssh/connect-serverless-feature-disabled: branch ✅ | main (e5cdfb9) ✅ | latest (v1.22.1) ❌

latest (v1.22.1):

acceptance_test.go:2016: Incomplete entry in ACC_REPLS: "{\"Literal\": \"\", \"New\": \"[RUN_ID]\", \"Order\": -100}"
    acceptance_test.go:1311: Diff:
        --- ssh/connect-serverless-feature-disabled/output.txt
        +++ /tmp/TestAcceptsshconnect-serverless-feature-disabled372759709/002/output.txt
        @@ -6,29 +6,8 @@
         === Reported error category
         
         >>> jq -r select(.path == "/telemetry-ext") | .body.protoLogs[] | fromjson | .entry.databricks_cli_log.ssh_tunnel_event.error_category [OUTPUT_DIR]/out.requests.txt
        -DRIVER_PROXY_FORBIDDEN
        +BINARY_UPLOAD_FAILED
         
         === Each release archive is uploaded once, and the submitted run is cancelled
         
         >>> print_requests.py //api/2.0/workspace-files/import-file //api/2.2/jobs/runs/cancel
        -{
        -  "method": "POST",
        -  "path": "/api/2.0/workspace-files/import-file/Workspace/Users/[USERNAME]/.databricks/ssh-tunnel/[CLI_VERSION]/databricks_cli_linux_amd64/databricks.zip",
        -  "q": {
        -    "overwrite": "true"
        -  }
        -}
        -{
        -  "method": "POST",
        -  "path": "/api/2.0/workspace-files/import-file/Workspace/Users/[USERNAME]/.databricks/ssh-tunnel/[CLI_VERSION]/databricks_cli_linux_arm64/databricks.zip",
        -  "q": {
        -    "overwrite": "true"
        -  }
        -}
        -{
        -  "method": "POST",
        -  "path": "/api/2.2/jobs/runs/cancel",
        -  "body": {
        -    "run_id": [RUN_ID]
        -  }
        -}
        
    acceptance_test.go:1311: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1311
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1093
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:641
        	Error:      	Not equal: 
        	            	expected: "Connecting to feature-disabled...\nUploading binaries...\nStarting SSH server...\nJob submitted successfully with run ID: [RUN_ID]\nError: failed to ensure that ssh server is running: the workspace refused the SSH tunnel connection: FEATURE_DISABLED: An administrator has disabled port forwarding to serverless compute for this workspace, which includes the SSH tunnel used by `databricks ssh connect`\n"
        	            	actual  : "Connecting to feature-disabled...\nUploading binaries...\nError: failed to upload ssh-tunnel binaries: failed to get archive for architecture amd64: failed to open [TEST_TMP_DIR]/releases/databricks_cli_[CLI_VERSION]_linux_amd64.zip: open [TEST_TMP_DIR]/releases/databricks_cli_[CLI_VERSION]_linux_amd64.zip: no such file or directory\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,5 +2,3 @@
        	            	 Uploading binaries...
        	            	-Starting SSH server...
        	            	-Job submitted successfully with run ID: [RUN_ID]
        	            	-Error: failed to ensure that ssh server is running: the workspace refused the SSH tunnel connection: FEATURE_DISABLED: An administrator has disabled port forwarding to serverless compute for this workspace, which includes the SSH tunnel used by `databricks ssh connect`
        	            	+Error: failed to upload ssh-tunnel binaries: failed to get archive for architecture amd64: failed to open [TEST_TMP_DIR]/releases/databricks_cli_[CLI_VERSION]_linux_amd64.zip: open [TEST_TMP_DIR]/releases/databricks_cli_[CLI_VERSION]_linux_amd64.zip: no such file or directory
        	            	 
        	Test:       	TestAccept/ssh/connect-serverless-feature-disabled
        	Messages:   	ssh/connect-serverless-feature-disabled/out.connect.txt vs /tmp/TestAcceptsshconnect-serverless-feature-disabled372759709/001/out.connect.txt

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: f0fd02e

Run: 39935527440

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 281 26 4:02
✅​ aws-windows-latest-4core-16gb 283 24 3:10
✅​ azure linux-2core-8gb 280 26 4:04
✅​ azure-windows-latest-4core-16gb 282 24 3:07
✅​ gcp linux-2core-8gb 281 26 4:04
✅​ gcp-windows-latest-4core-16gb 283 24 3:09
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:04 aws-windows-latest-4core-16gb TestAccept
3:03 gcp-windows-latest-4core-16gb TestAccept
3:01 azure-windows-latest-4core-16gb TestAccept

@denik
denik marked this pull request as ready for review October 21, 2026 14:56
@denik
denik force-pushed the denik/remove-databricks-bundle-engine branch from ab689d4 to b6eb4d2 Compare October 21, 2026 14:59
@denik denik changed the title acc: Reject EnvMatrix.DATABRICKS_BUNDLE_ENGINE acc: Clean up and reject EnvMatrix.DATABRICKS_BUNDLE_ENGINE Oct 21, 2026
@denik
denik enabled auto-merge October 21, 2026 15:02
denik and others added 2 commits October 23, 2026 11:54
The direct engine is the only engine, so pinning it in EnvMatrix does nothing.
Remove the leftover pins and fail tests that add one.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik force-pushed the denik/remove-databricks-bundle-engine branch from b6eb4d2 to 34a6345 Compare October 23, 2026 09:54
…anager

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit edebd84 Oct 23, 2026
32 checks passed
@denik
denik deleted the denik/remove-databricks-bundle-engine branch October 23, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants