Repository navigation
Record the sign-in region in the cached login token - #10767
Open
AndrewAsseily wants to merge 2 commits into
Open
AndrewAsseily wants to merge 2 commits into
AndrewAsseily wants to merge 2 commits into
Conversation
Member
|
Should we handle the CLI's own refresh flow while we're here? aws-cli/awscli/botocore/credentials.py Lines 2560 to 2566 in 10b7b71 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
aws logincaches a refresh token, and refresh tokens are regional: they have to be redeemed in the region they were issued in. Nothing currently records where the login happened, so a refresh goes to whatever region resolves when it runs. This writes that region into the cached token assignInRegion. The value is the same region used to build the signin client for the login itself, so it reflects where the sign-in actually wentNothing reads the field yet: the SDK side is separate. On its own this is backwards compatible, since existing readers ignore unknown fields in the token file and tokens cached before this change just won't have it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.