Repository navigation
Conversation
Convert Variant nanosecond timestamps to microseconds before applying the existing coarse temporal redaction, matching typed timestamps. Signed-off-by: Yanzhi Xin <erindotsing@gmail.com>
autoCAT6
force-pushed
the
codex/variant-nanos-sanitization
branch
2 times, most recently
from
October 16, 2026 02:54
9145acc to
ea37574
Compare
uros-b
reviewed
Oct 16, 2026
uros-b
left a comment
Member
There was a problem hiding this comment.
Nice fix, thank you @autoCAT6 for working on this!
Let's ping @singhpk234 and @RussellSpitzer here
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant nanosecond timestamps are passed to the microsecond-based sanitizer without conversion, so timestamps near the current time lose the coarse temporal description that equivalent microsecond values retain. Normalize both nanosecond Variant timestamp types to microseconds before sanitization, matching typed timestamp-ns handling and retaining the existing redaction policy.
Test plan: Verify with/without-time-zone timestamps at now and ±90 minutes, with microsecond controls, through bound/unbound expressions and diagnostic strings. The same 12 regressions fail for 6 nanos inputs before the change and all pass after it. API build: 1301 passed, 1 skipped; checkstyle, formatting, and API compatibility checks passed.