Repository navigation
HIVE-30150: Implement ETag-based freshness-aware table loading for HMS Iceberg REST Catalog - #6891
Open
Aggarwal-Raghav wants to merge 2 commits into
Open
Aggarwal-Raghav wants to merge 2 commits into
Aggarwal-Raghav wants to merge 2 commits into
Conversation
…S Iceberg REST Catalog
| @Override | ||
| protected void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doHead(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doHead(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doPost(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doPost(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doDelete(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
| @Override | ||
| protected void doDelete(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException { | ||
| execute(ServletRequestContext.from(request), response); |
- Prevent servlet stack trace leakage (Sonar S1989 / CWE-209) - Reduce complexity of HMSCatalogAdapter#execute (Sonar S3776) - Add RFC 9110 weak ETag comparison (W/) in matchesETag - Add end-to-end integration test in BaseRESTCatalogTests - Add stageCreate unit test in TestHMSCatalogAdapterETag - Remove unused Route field and dead servlet methods
Aggarwal-Raghav
marked this pull request as ready for review
October 18, 2026 11:54
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implemented freshness-aware table loading in HMSCatalogAdapter by computing and returning an ETag HTTP response header for table operations (CREATE_TABLE, REGISTER_TABLE, UPDATE_TABLE, LOAD_TABLE). Added RFC 9110–compliant evaluation of incoming If-None-Match headers, returning 304 Not Modified when table metadata is unchanged.
Why are the changes needed?
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Wrote Junit tests.