Skip to content

bug: On applying any ext-plugin-post-resp, any header set by upstream service was not passed to downstream #254

Open
Open
bug: On applying any ext-plugin-post-resp, any header set by upstream service was not passed to downstream#254

Description

@abhi0476
abhi0476
opened on Jul 11, 2023

If we apply any ext-plugin-post-resp filter any header set by upstream service was not passed to downstream.

Also There is no provision for setting multiple headers as headers is made as private Map<String, String> headers; instead it should be private Map<String, List> headers in PostResponse.java and PostRequest.java

Environment

  • apisix-runner-starter 0.4.0

Minimal test code / Steps to reproduce the issue

  1. Apply any developed filter on ext-plugin-post-resp
  2. Set some header say cookie on upstream server
  3. Check response on httpclient, upstream headers has been ommitted

What's the actual result? (including assertion message & call stack if applicable)

Headers is not available on downstream

What's the expected result?

Headers should be available on downstream

Attaching a fix for the same
apisix.zip

Activity

  1. moonming
    added this to ⚡️ Apache APISIX Roadmapon Jul 11, 2023
  2. moonming
    moved this to 🏗 In progress in ⚡️ Apache APISIX Roadmapon Jul 11, 2023
  3. moonming
    moved this from 🏗 In progress to 👀 In review in ⚡️ Apache APISIX Roadmapon Jul 11, 2023

  4. Sn0rt commented on Jul 13, 2023

    @Sn0rt
    Sn0rt
    on Jul 13, 2023

    thx you very much. and can you create a PR ?

  5. abhi0476 commented on Jul 13, 2023

    @abhi0476
    abhi0476
    on Jul 13, 2023
    Author

    thx you very much. and can you create a PR ?
    How to do that? In which branch should I commit and push first?

  6. juzhiyuan commented on Jul 14, 2023

    @juzhiyuan
    juzhiyuan
    on Jul 14, 2023
    Member

    Hi @abhi0476,

    1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
    2. Commit changes to the main branch
    3. Submit a PR
  7. abhi0476
    added a commit that references this issue on Jul 14, 2023

    Changs for Bug: apache#254

    96ca606

  8. abhi0476 commented on Jul 14, 2023

    @abhi0476
    abhi0476
    on Jul 14, 2023
    Author

    Hi @abhi0476,

    1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
    2. Commit changes to the main branch
    3. Submit a PR

    Done

  9. abhi0476
    added 2 commits that reference this issue on Jul 18, 2023

    Changs for Bug: apache#254

    dfb22aa

    Changs for Bug: apache#254

    84b6753
  10. abhi0476
    added 3 commits that reference this issue on Aug 9, 2023

    Changs for Bug: apache#254

    08fb475

    Changs for Bug: apache#254

    09055ae

    Changs for Bug: apache#254

    6c36457
  11. abhi0476
    added a commit that references this issue on Aug 17, 2023

    Changes for Bug: apache#254

    9b6f076
  12. Revolyssup
    moved this from 👀 In review to 🏗 In progress in ⚡️ Apache APISIX Roadmapon Nov 1, 2023
  13. Baoyuantop
    moved this from 🏗 In progress to 📋 Backlog in ⚡️ Apache APISIX Roadmapon Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions