Repository navigation
[v3-4-test] Do not warn about bare postgresql:// metadata DB URLs (#74863) - #74884
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…4863) The bare postgresql scheme is valid in SQLAlchemy; Airflow only rewrites it to make the driver explicit. It nevertheless emitted the old "Bad scheme ... You must change to postgresql+psycopg" FutureWarning, which users read as driver-less URLs being deprecated. Only warn for the unsupported postgres and postgres+psycopg2 schemes, reword that warning (no outdated SQLAlchemy 1.4 / Airflow 2.3 reference or release deadline), update the docstring, and add a test. (cherry picked from commit 8317410) Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare postgresql scheme is valid in SQLAlchemy; Airflow only rewrites
it to make the driver explicit. It nevertheless emitted the old "Bad
scheme ... You must change to postgresql+psycopg" FutureWarning, which
users read as driver-less URLs being deprecated.
Only warn for the unsupported postgres and postgres+psycopg2 schemes,
reword that warning (no outdated SQLAlchemy 1.4 / Airflow 2.3 reference
or release deadline), update the docstring, and add a test.
(cherry picked from commit 8317410)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com