You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue will track the progress of the v2 version of setup-java.
One of the core goals of the v2 version is to support downloading different distributions of Java. Currently Zulu builds of OpenJDK are downloaded and installed but with v2 we will be adding support for adoptOpenJDK builds of OpenJDK as well. Because this is a major change, a v2 major update is warranted.
One of the main goals of v2 is also to make setup-java extensible so that other distributions can be supported as well.
Major TODO items:
Create ADR that outlines and documents the roadmap and plan for the v2 version: V2 setup-java ADR #97
Accept ADR after getting feedback from the community
Create v2-preview branch
Implement all the necessary changes and merge them into the v2-preview branch
Gather feedback and test using the v2-preview branch
After being comfortable with the v2-preview changes, merge the branch into main
Update public docs, and starter workflow to use v2 instead of v1 tags
I would suggest changing the stated goal (in the PR and ADR) to adding support for multiple distos (rather than a specific one). I believe that is the actual subject for which there is wide demand and support.
I would also propose that we add a goal to address #84 (built in use of caching) in v2, as this will likely significantly improve workflow execution times and reduce bandwidth requirements.
Another (seemingly minor, but affects expected output) item I’d propose to see addressed in v2 is #92
@maxim-lobanov should Setup Java really continue to have the support for managing Maven's settings.xml ? Shouldn't that be done by a Maven-specific Action?
Hello @davidkarlsen. We released setup-java@v2-preview two weeks ago. We're planing to release stable setup-java@v2 next week. But If you want to try current logic for v2 you can use actions/setup-java@v2-preview. #98 (comment)
Activity
giltene commentedon Aug 26, 2020
I would suggest changing the stated goal (in the PR and ADR) to adding support for multiple distos (rather than a specific one). I believe that is the actual subject for which there is wide demand and support.
I would also propose that we add a goal to address #84 (built in use of caching) in v2, as this will likely significantly improve workflow execution times and reduce bandwidth requirements.
Another (seemingly minor, but affects expected output) item I’d propose to see addressed in v2 is #92
maxim-lobanov commentedon Mar 15, 2021
Hello!
V2-preview is available with support of Adopt OpenJDK. We would be appreciate for any testing before
v2stable release:README for v2-preview: https://github.com/actions/setup-java/tree/v2-preview
brunoborges commentedon Mar 17, 2021
@maxim-lobanov should Setup Java really continue to have the support for managing Maven's settings.xml ? Shouldn't that be done by a Maven-specific Action?
I feel this is an overeach of functionality.
msgilligan commentedon Mar 22, 2021
The v2-preview README doesn't document that
outputs.pathandoutputs.versionare set. This would be very helpful.maxim-lobanov commentedon Mar 22, 2021
Thank you for pointing on it. Actually,
v2-previewsetspath,versionanddistributionproperties: https://github.com/actions/setup-java/blob/v2-preview/src/distributions/base-installer.ts#L125 . I think we need to document it.davidkarlsen commentedon Mar 30, 2021
how is it coming along? It's now 8 months since the ADR was created..
dmitry-shibanov commentedon Mar 30, 2021
Hello @davidkarlsen. We released
setup-java@v2-previewtwo weeks ago. We're planing to release stablesetup-java@v2next week. But If you want to try current logic forv2you can useactions/setup-java@v2-preview.#98 (comment)
konradpabjan commentedon Apr 5, 2021
Docs and starter workflows have been updated! Closing out