Hide/remove Java installations logs from v2 #157

Activity

1. asarkar

   added

   feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic

   needs triage

   on Apr 7, 2021
2. dmitry-shibanov

   removed

   needs triage

   on Apr 7, 2021
3. maxim-lobanov commented on Apr 8, 2021

   

   maxim-lobanov

   on Apr 8, 2021

   Contributor

   More actions

   @asarkar thank you for raising this point.

   v2 provides less output if using pre-cached version on Hosted runners:

   Resolved Java 11.0.10+9 from tool-cache
   Setting Java 11.0.10+9 as the default
   
   Java configuration:
     Distribution: adopt
     Version: 11.0.10+9
     Path: /Users/runner/hostedtoolcache/Java_Adopt_jdk/11.0.10-9/x64/Contents/Home
   
   Creating settings.xml with server-id: github
   Writing to /Users/runner/.m2/settings.xml
   

   We have discussed it internally and we would like to keep this level of verbosity by default for cases when Java is downloading in runtime because in our understanding it will be easier to track the actual progress and debug in case of any issues
4. asarkar commented on Apr 8, 2021

   

   asarkar

   on Apr 8, 2021

   Last edited by asarkar

   Author

   More actions

   If you want to debug, why don't you introduce a flag to enable verbose logging as is done in most software, instead of asking the user to accept logs they've no use for? Just like distribution, a verbose flag can be introduced that'll be false by default, and true for debugging purposes.
   No one runs production code with verbose logging unless they specifically enable it. Why'd this software be any different?
5. maxim-lobanov commented on Apr 8, 2021

   

   maxim-lobanov

   on Apr 8, 2021

   Contributor

   More actions

   We don't consider current output as verbose logging. The output that you have shared is normal logging and the information is useful to understand what action does at this moment. I guess any tool reports to the output the current progress of running command.

   Verbosity logging can be enabled by the following guide: https://docs.github.com/en/actions/managing-workflow-runs/enabling-debug-logging
   And it will produce even more logs, see example in https://github.com/maxim-lobanov/test-repo/runs/2294998433?check_suite_focus=true

   👍React with 👍1Reacted by Konrad Pabjan
6. konradpabjan commented on Apr 8, 2021

   

   konradpabjan

   on Apr 8, 2021

   Last edited by konradpabjan

   Contributor

   More actions

   I share the same sentiment as @maxim-lobanov , the current output is very very limited for an action (less than 20 lines). There should always be some information logged by default. There was even even this request to log more information which is a pretty clear indication that we weren't logging enough and this information is useful for users: #92

   Verbose logging should only be used for things like extra information. @actions/upload-artifact is a good example where debug logs tell you things like the upload time of each file, the resource URLs and a host of other information. See: https://github.com/konradpabjan/artifact-test/runs/2282151605?check_suite_focus=true#step:3:27

   No one runs production code with verbose logging unless they specifically enable it

   The vast majority of GitHub actions users unfortunately do not have step debugging enabled.

   Users shouldn't have to turn on debugging to see very basic things so I'm going to label this as-designed since we won't be changing this.
7. konradpabjan

   added

   *as-designedDescribed behavior is as designedDescribed behavior is as designed

   and removed

   feature requestNew feature or request to improve the current logicNew feature or request to improve the current logic

   on Apr 8, 2021
8. konradpabjan

   closed this as completedon Apr 8, 2021