Skip to content

[Backfill] Fix potential multi-commit of the same shard into combined table after backfill resume - #476

Merged
george-zubrienko merged 8 commits into
mainfrom
sql-fix
Jul 13, 2026
Merged

george-zubrienko merged 8 commits into
mainfrom
sql-fix

Conversation

@george-zubrienko

Copy link
Copy Markdown
Contributor

Fixes #473

@github-code-quality

github-code-quality Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: Java

Java / code-coverage/jacoco

The overall coverage in the sql-fix branch is 74%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.
File main sql-fix 7a4ba20 +/-
services/iceber...logWriter.scala — 97% —
services/synaps...xtensions.scala — 96% —
models/cdm/CdmParser.scala — 88% —
services/mssql/...yProvider.scala — 88% —
services/iceber...onScanner.scala — 86% —
services/iceber...nversions.scala — 84% —
services/stream...undShaper.scala — 82% —
services/mssql/...ingSource.scala — 81% —
services/synaps...ingSource.scala — 71% —
utils/SqlUtils.scala — 54% —

Updated July 13, 2026 13:09 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@s-vitaliy s-vitaliy left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment with question. The new code coverage action sucks 🙂

Comment thread src/main/scala/services/backfill/DefaultBackfillStateManager.scala
@george-zubrienko
george-zubrienko merged commit d84d0c0 into main Jul 13, 2026
1 check passed
@george-zubrienko
george-zubrienko deleted the sql-fix branch July 13, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharded SQL Server backfill process duplicates rows (corresponding to shard size) in the target table

2 participants