Repository navigation
[Refactor] Build theme role filter with Object.fromEntries - #8904
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The role filter passed to
Filterinshopify theme listwas built with areducewhose accumulator was mutated on each iteration. It is a plain key-to-value mapping, so the accumulator adds noise without adding anything.WHAT is this pull request doing?
Builds the per-role flags in
packages/theme/src/cli/services/list.tswithObject.fromEntriesoverALLOWED_ROLESand names the resultselectedRoles, so the spread intoFilterreads as "one boolean per allowed role". TheFilterPropsimport was only needed to type the accumulator and is now dropped. Behavior is unchanged.How to manually test your changes?
Each should list the same themes as before the change.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add