Skip to content

fix(windows): only list displays of the configured adapter - #5891

Open
abbradar wants to merge 1 commit into
LizardByte:masterfrom
abbradar:fix/capture-honor-adapter-name
Open

abbradar wants to merge 1 commit into
LizardByte:masterfrom
abbradar:fix/capture-honor-adapter-name

Conversation

@abbradar

Copy link
Copy Markdown

Description

display_names() listed the outputs of every adapter, but display_base_t::init() only opens those of adapter_name, so streams failed with "Failed to locate an output device" when another adapter's display enumerated first. Skip other adapters' displays there too.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

Checked that on a machine with two adapters with two different connected screens, selecting the adapter now also selects the correct screen/

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR
    Debugged this with Claude Opus 5.5.

display_names() listed the outputs of every adapter, but
display_base_t::init() only opens those of adapter_name, so streams failed
with "Failed to locate an output device" when another adapter's display
enumerated first. Skip other adapters' displays there too.
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant