Skip to content

The Linux gradle wrapper should always use eol=lf as line endings - #12124

Merged
kiview merged 1 commit into
testcontainers:mainfrom
AB-xdev:correct-gitattributes
Oct 20, 2026
Merged

kiview merged 1 commit into
testcontainers:mainfrom
AB-xdev:correct-gitattributes

Conversation

@AB-xdev

@AB-xdev AB-xdev commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Currently when you e.g. checkout the repo on Windows gradlew will use \r\n as line endings which will subsequently not work when you mount it into Linux environment like a container.

Summary by CodeRabbit

  • Chores
    • Standardized line endings for the Gradle Wrapper script to improve consistency across environments.

@AB-xdev
AB-xdev requested a review from a team as a code owner October 20, 2026 12:14
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e94a1b5-662e-4117-b3b8-d04f5785f17f
📥 Commits

Reviewing files that changed from the base of the PR and between 6cc7f8d and 00045c2.

📒 Files selected for processing: 1
  • .gitattributes

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The .gitattributes file adds an LF line-ending rule for gradlew. The existing rule for .sh files remains unchanged.

Changes: Line-ending rules

Layer / File(s) Summary
Set Gradle Wrapper line endings
.gitattributes
A comment and an LF line-ending rule are added for gradlew. The existing .sh rule remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: bsideup

Merge Risk: ⚪ Minimal · up to 00045

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the Windows checkout issue, the resulting CRLF line endings, and the Linux container failure. It also describes the proposed fix. No issue reference is required becaus…
Title check Passed The title clearly identifies the main change: enforcing LF line endings for the Linux Gradle wrapper. It is concise and specific.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the Windows checkout issue, the resulting CRLF line endings, and the Linux container failure. It also describes the proposed fix. No issue reference is required because none is provided.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kiview kiview added this to the next milestone Oct 20, 2026
@kiview
kiview merged commit 57cc34e into testcontainers:main Oct 20, 2026
102 checks passed
@AB-xdev
AB-xdev deleted the correct-gitattributes branch October 21, 2026 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants