Skip to content

Commit 8c57f6c

Browse files
github-actions[bot]github-actionsmcollina
authored
[Release] v6.29.1 (#6023)
* Bumped v6.29.1 * test: make security regression tests portable Signed-off-by: Matteo Collina <hello@matteocollina.com> (cherry picked from commit 1a69237) --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Matteo Collina <hello@matteocollina.com>
1 parent 39f93e1 commit 8c57f6c

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "undici",
3-
"version": "6.29.0",
3+
"version": "6.29.1",
44
"description": "An HTTP/1.1 client, written from scratch for Node.js",
55
"homepage": "https://undici.nodejs.org",
66
"bugs": {

‎test/node-test/agent.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ test('forwards TLS certificate validation callbacks via tls option', async (t) =
842842
t.after(() => agent.close())
843843

844844
await assert.rejects(
845-
request(`https://localhost:${server.address().port}`, { dispatcher: agent }),
845+
request(`https://127.0.0.1:${server.address().port}`, { dispatcher: agent }),
846846
/rejected by custom checkServerIdentity/
847847
)
848848
assert.strictEqual(identityChecks, 1)
@@ -874,7 +874,7 @@ test('forwards TLS certificate validation callbacks via connect option', async (
874874
t.after(() => agent.close())
875875

876876
await assert.rejects(
877-
request(`https://localhost:${server.address().port}`, { dispatcher: agent }),
877+
request(`https://127.0.0.1:${server.address().port}`, { dispatcher: agent }),
878878
/rejected by custom checkServerIdentity/
879879
)
880880
assert.strictEqual(identityChecks, 1)
@@ -903,7 +903,7 @@ test('copies connect and tls options before storing them', async (t) => {
903903

904904
connect.timeout = 200
905905
tls.servername = 'agent2'
906-
await request(`http://localhost:${server.address().port}`, { dispatcher: agent })
906+
await request(`http://127.0.0.1:${server.address().port}`, { dispatcher: agent })
907907

908908
assert.notStrictEqual(capturedOptions.connect, connect)
909909
assert.notStrictEqual(capturedOptions.tls, tls)

‎test/tls-renegotiation.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { constants } = require('node:crypto')
55
const { once } = require('node:events')
66
const { readFileSync } = require('node:fs')
77
const { join } = require('node:path')
8-
const { createServer } = require('node:tls')
8+
const { createServer, TLSSocket } = require('node:tls')
99
const { test } = require('node:test')
1010

1111
const { Client } = require('..')
@@ -20,10 +20,11 @@ const wrongHost = {
2020
cert: readFileSync(join(fixtures, 'wrong-cert.pem'))
2121
}
2222
const ca = readFileSync(join(fixtures, 'ca.pem'))
23+
const skip = typeof TLSSocket.prototype.setKeyCert !== 'function'
2324

2425
// @see https://github.com/nodejs/undici/security/advisories/GHSA-qrxm-fqhp-jwvm
2526
for (const protocol of ['http/1.1', 'h2']) {
26-
test(`TLS certificate errors after ${protocol} connection establishment reject the request`, async (t) => {
27+
test(`TLS certificate errors after ${protocol} connection establishment reject the request`, { skip }, async (t) => {
2728
let startRenegotiation
2829
const renegotiationStarted = new Promise((resolve) => {
2930
startRenegotiation = resolve

0 commit comments

Comments
 (0)